Re: TAP / recovery-test fs-level backups, psql enhancements etc

On 4 March 2016 at 05:08, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:

>
> Okay, so far I have pushed 0001 and 0002 squashed (commit 5bec1ad4648),
> 0003 (commit 7d9a4301c08), 0005 and 0006 squashed (commit 2c83f435a3de).
> In the last one I chose to rename your psql_check to safe_psql and
> tweaked a few other things, not worthy of individual mention. I think
> the result should still work on Perl 5.8 though I didn't actually verify
> that -- I don't think I made any changes that would affect portability.
> I will be downloading your Dockerized stuff shortly while I still have a
> convenient network connection, just in case.
>
>
Thanks very much. Your commit messages are much better too.

Patches 0004 and 0007 remain.

For readers who're not following closely that's the filtering support for
RecursiveCopy and the support for taking filesystem-level backups in
PostgresNode that uses it.

> I think 0007 is uncontroversial; I
> reworked 0004 a bit and gave it to someone else to finish a couple of
> didn't I didn't quite like -- hopefully she'll be submitting a new
> version soonish. Once we have that I'm happy to push them too.

Great, thanks.

>
> > I don't expect to be doing much more on the framework at this point as I
> > want to be able to get back to the code I had to enhance the framework in
> > order to test....
>
> How come!?!?

This yak grows hair faster than I can shave it ;)

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services