Re: TAP / recovery-test fs-level backups, psql enhancements etc

From: Craig Ringer <craig(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Subject: Re: TAP / recovery-test fs-level backups, psql enhancements etc
Date: 2016-03-03 05:20:17
Message-ID: CAMsr+YG1R2BOP-w9-hde_DbTHZxED+Tqn0YbydqXtb1tg4DDaw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3 March 2016 at 05:26, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> wrote:

>
> Pushed it with that fix. I also added a further "data_" prefix, so it's
> "data_${name}_XXXX" now. Hopefully this is less problematic than
> yesterday's ...
>
>
On the Perl 5.8.8 test env I've set up now, per

http://www.postgresql.org/message-id/CAMsr+YGR6pU-gUyp-FT98XwXAsc9n6j-awZAqxvW_+P3RTC7cg@mail.gmail.com

master currently fails with

t/004_timeline_switch....."remove_tree" is not exported by the File::Path
module

remove_tree is only in File::Path 2.07 but Perl 5.8.8 has 1.08. No
buildfarm member has complained, so clearly we don't actually test with the
stated supported Perl version.

The attached patch fixes it to use the legacy File::Path interface 'rmtree'
so master runs on 588 again.

--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
0001-TAP-File-Path-remove_tree-is-new-in-2.x-use-1.x-rmtr.patch text/x-patch 1.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2016-03-03 05:23:42 Re: TAP / recovery-test fs-level backups, psql enhancements etc
Previous Message Haribabu Kommi 2016-03-03 05:16:31 Re: pg_hba_lookup function to get all matching pg_hba.conf entries