| From: | Craig Ringer <craig(at)2ndquadrant(dot)com> |
|---|---|
| To: | Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> |
| Cc: | David Steele <david(at)pgmasters(dot)net>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Proposal: Generic WAL logical messages |
| Date: | 2016-03-17 12:42:45 |
| Message-ID: | CAMsr+YE0=Ma-MUm67-Vg6ku4zSvRvXtB+uk0UiXk3QObrZkdWg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 17 March 2016 at 19:08, Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> wrote:
> On 16.03.2016 18:56, David Steele wrote:
>
>>
>> This patch applies cleanly and is ready for review with no outstanding
>> issues that I can see. Simon and Artur, you are both signed up as
>> reviewers. Care to take a crack at it?
>>
>> Thanks,
>>
>>
> I have tested the patch once again and have looked the code. It looks good
> for me. I haven't any observation.
>
> The patch does its function correctly. I have tested it with a plugin,
> which writes DDL queries to the WAL using a hook and replicates this
> queries at subscribers.
>
Would you mind sharing the plugin here? I could add it to src/test/modules
and add some t/ tests so it runs under the TAP test framework.
--
Craig Ringer http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2016-03-17 12:53:38 | Re: Performance degradation in commit ac1d794 |
| Previous Message | Tomas Vondra | 2016-03-17 12:36:36 | Re: Proposal: Generic WAL logical messages |