| From: | Nitin Jadhav <nitinjadhavpostgres(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Inconsistency in reporting checkpointer stats |
| Date: | 2023-02-19 09:57:31 |
| Message-ID: | CAMm1aWZfo0pLm0rJjyi=Ucte1eGibumWT2VtQ4qMW-DTxEtaTw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> This doesn't pass the tests, because the regression tests weren't adjusted:
> https://api.cirrus-ci.com/v1/artifact/task/5937624817336320/testrun/build/testrun/regress/regress/regression.diffs
Thanks for sharing this. I have fixed this in the patch attached.
>> IMO, there's no need for 2 separate patches for these changes.
> I will make it a single patch while sharing the next patch.
Clubbed both patches into one.
Thanks & Regards,
Nitin Jadhav
On Tue, Feb 14, 2023 at 6:08 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
>
> On 2022-12-21 17:14:12 +0530, Nitin Jadhav wrote:
> > Kindly review and share your comments.
>
> This doesn't pass the tests, because the regression tests weren't adjusted:
>
> https://api.cirrus-ci.com/v1/artifact/task/5937624817336320/testrun/build/testrun/regress/regress/regression.diffs
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Fix-inconsistency-in-reporting-checkpointer-stats.patch | application/octet-stream | 9.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | wangw.fnst@fujitsu.com | 2023-02-19 13:06:02 | RE: Rework LogicalOutputPluginWriterUpdateProgress |
| Previous Message | Peter Eisentraut | 2023-02-19 07:25:57 | Re: Handle TEMP_CONFIG for pg_regress style tests in pg_regress.c |