From: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Teodor Sigaev <teodor(at)sigaev(dot)ru>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [BUGS] BUG #14155: bloom index error with unlogged table |
Date: | 2016-06-04 03:27:05 |
Message-ID: | CAMkU=1xjLbJA7tXmLxME87JZA921Q4FyLb-8kZCNQJgtAwfJ7Q@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-bugs pgsql-hackers |
On Thu, Jun 2, 2016 at 9:03 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> I wrote:
>> Jeff Janes <jeff(dot)janes(at)gmail(dot)com> writes:
>>> My biggest gripe with it at the moment is that the signature size should be
>>> expressed in bits, and then internally rounded up to a multiple of 16,
>>> rather than having it be expressed in 'uint16'.
>>> If that were done it would be easier to fix the documentation to be more
>>> understandable.
>
>> +1 ... that sort of definition seems much more future-proof, too.
>> IMO it's not too late to change this. (We probably don't want to change
>> the on-disk representation of the reloptions, but we could convert from
>> bits to words in bloptions().)
>
> There were no objections to this, but also no action. Attached is a draft
> patch ... any complaints?
One thing from the commit-message:
"On-disk, we can still store it in words, so as to not break on-disk
compatibility with beta1."
Hasn't that ship already sailed?
from beta1 to HEAD:
The database cluster was initialized with CATALOG_VERSION_NO
201605051, but the server was compiled with CATALOG_VERSION_NO
201605191.
Or is the concern about intra-version pg_upgrade rather than direct
on-disk compatibility?
Cheers,
Jeff
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-06-04 03:55:34 | Re: [BUGS] BUG #14155: bloom index error with unlogged table |
Previous Message | Jeff Janes | 2016-06-04 02:43:56 | Re: After upgrade to 9.5 space not being released |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-06-04 03:41:24 | Re: Reviewing freeze map code |
Previous Message | Robert Haas | 2016-06-04 03:13:36 | Re: [sqlsmith] Failed assertions on parallel worker shutdown |