Re: [BUGS] BUG #14155: bloom index error with unlogged table

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #14155: bloom index error with unlogged table
Date: 2016-06-03 04:03:00
Message-ID: 23767.1464926580@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

I wrote:
> Jeff Janes <jeff(dot)janes(at)gmail(dot)com> writes:
>> My biggest gripe with it at the moment is that the signature size should be
>> expressed in bits, and then internally rounded up to a multiple of 16,
>> rather than having it be expressed in 'uint16'.
>> If that were done it would be easier to fix the documentation to be more
>> understandable.

> +1 ... that sort of definition seems much more future-proof, too.
> IMO it's not too late to change this. (We probably don't want to change
> the on-disk representation of the reloptions, but we could convert from
> bits to words in bloptions().)

There were no objections to this, but also no action. Attached is a draft
patch ... any complaints?

regards, tom lane

Attachment Content-Type Size
bloom-express-length-in-bits.patch text/x-diff 15.8 KB

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2016-06-03 06:11:59 Re: [BUGS] BUG #14155: bloom index error with unlogged table
Previous Message Devrim Gündüz 2016-06-02 23:09:33 Re: BUG #14172: RPM repository for i386 not working, repomd.xml file is missing.

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2016-06-03 04:21:08 Re: Rename max_parallel_degree?
Previous Message David G. Johnston 2016-06-03 03:44:24 Re: Prepared statements and generic plans