Re: effective_io_concurrency in 9.6beta

On Tue, May 24, 2016 at 11:34 AM, Alvaro Herrera
<alvherre(at)2ndquadrant(dot)com> wrote:
> Tom Lane wrote:
>> Jeff Janes <jeff(dot)janes(at)gmail(dot)com> writes:
>> > commit 1aba62ec made zero be an illegal value for effective_io_concurrency.
>> > i think this was an accident. If not, then the sample postgresql.conf
>> > (at least) needs to be updated.
>>
>> It looks like the problem is that the new range check
>>
>> + /* This range check shouldn't fail, but let's be paranoid */
>> + return (new_prefetch_pages > 0.0 && new_prefetch_pages < (double) INT_MAX);
>>
>> should be testing for >= 0.0 not > 0.0.
>
> Hmm, yeah, it looks like that's it. Will fix.
>

Thanks, works as expected now.

Cheers,

Jeff