Re: 9.5rc1 brin_summarize_new_values

From: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: 9.5rc1 brin_summarize_new_values
Date: 2015-12-27 00:04:12
Message-ID: CAMkU=1wMUoUV=CewYd3Xr3HB_BWXCRRUX1Cyce9MNqVXVA5c6Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Dec 26, 2015 at 8:27 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>> On Sat, Dec 26, 2015 at 7:10 AM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
>>> brin_summarize_new_values() does not check that it is called on the
>>> correct type of index, nor does it check permissions.
>
>> Yeah, it should have those sanity checks...
>
> Yeah, that is absolutely a must-fix.

Thanks for committing the fix.

Another issue is: it seems to have no SGML documentation. Is that OK?

Cheers,

Jeff

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2015-12-27 00:57:54 Re: 9.5rc1 brin_summarize_new_values
Previous Message Pavel Stehule 2015-12-26 20:44:51 Re: Add numeric_trim(numeric)