Re: 9.5rc1 brin_summarize_new_values

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: 9.5rc1 brin_summarize_new_values
Date: 2015-12-27 00:57:54
Message-ID: 20151227005754.GC58441@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jeff Janes wrote:
> On Sat, Dec 26, 2015 at 8:27 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
> >> On Sat, Dec 26, 2015 at 7:10 AM, Jeff Janes <jeff(dot)janes(at)gmail(dot)com> wrote:
> >>> brin_summarize_new_values() does not check that it is called on the
> >>> correct type of index, nor does it check permissions.
> >
> >> Yeah, it should have those sanity checks...
> >
> > Yeah, that is absolutely a must-fix.
>
> Thanks for committing the fix.

Yes, thanks.

> Another issue is: it seems to have no SGML documentation. Is that OK?

Hmm, I'm pretty sure I documented it somewhere. If this can wait till
Monday, I'll have a look by then.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2015-12-27 01:08:41 oldest/newestCommitTs output by pg_controldata
Previous Message Jeff Janes 2015-12-27 00:04:12 Re: 9.5rc1 brin_summarize_new_values