Re: Some dead code in get_param_path_clause_serials()

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Andrei Lepikhov <lepihov(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Some dead code in get_param_path_clause_serials()
Date: 2024-11-26 00:48:58
Message-ID: CAMbWs4_tC4teQuqPjbhtwTM930djDjUfjBUPoYgMiBWWdhzngQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Nov 13, 2024 at 9:59 PM Andrei Lepikhov <lepihov(at)gmail(dot)com> wrote:
> On 11/13/24 16:34, Richard Guo wrote:
> > The function get_param_path_clause_serials() is used to get the set of
> > pushed-down clauses enforced within a parameterized Path. Since we
> > don't currently support parameterized MergeAppend paths, and it
> > doesn't look like that is going to change anytime soon (as explained
> > in the comments for generate_orderedappend_paths), we don't need to
> > consider MergeAppendPath in this function. Is it worth removing the
> > related code, as attached?

> I've passed through the logic of
> get_param_path_clause_serials/reparameterize_path_by_child/reparameterize_path.
> Agree, it seems not useful to parameterise ordered appends in the near
> future.

Pushed. Thank you for review.

Thanks
Richard

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2024-11-26 00:49:04 Re: Use more CppAsString2() in pg_amcheck.c
Previous Message Richard Guo 2024-11-26 00:43:13 Re: Reordering DISTINCT keys to match input path's pathkeys