| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Andrei Lepikhov <lepihov(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, David Rowley <dgrowleyml(at)gmail(dot)com> |
| Subject: | Re: Reordering DISTINCT keys to match input path's pathkeys |
| Date: | 2024-11-26 00:43:13 |
| Message-ID: | CAMbWs4-umfOaTKtppL7mw0X312+bw5g8etJBQLLQ1MSuK1hr-w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Nov 22, 2024 at 5:40 PM Andrei Lepikhov <lepihov(at)gmail(dot)com> wrote:
> I wonder if it would be possible to print only three rows instead of 10
> to prove the DISTINCT's correctness.
There are ten distinct values in the 'distinct_tbl' test table, so
I think it’d better to print all of them to verify correctness.
> Also, to stabilise tests with parallel workers, I would recommend
> setting max_parallel_workers_per_gather into 1 and enabling
> debug_parallel_query.
Since we're testing sort-based DISTINCT, the results will always be
well-ordered, so they should be pretty stable as is.
I've applied some of the changes you suggested in your previous email
and pushed the updated patch. Thank you for your review.
Thanks
Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2024-11-26 00:48:58 | Re: Some dead code in get_param_path_clause_serials() |
| Previous Message | Peter Smith | 2024-11-26 00:14:50 | Re: Improve the error message for logical replication of regular column to generated column. |