Re: [PATCH] Correct RangeTblEntry.join_using_alias comment to reflect field order

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Steve Lau <stevelauc(at)outlook(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Correct RangeTblEntry.join_using_alias comment to reflect field order
Date: 2025-09-21 23:55:58
Message-ID: CAMbWs4_=RQN+KxuPvBa1XPYCbd6DbiuGzdeLQ6=TaC=3gRBfOw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Sep 21, 2025 at 11:54 PM Steve Lau <stevelauc(at)outlook(dot)com> wrote:
> Found a tiny incorrect comment of RangeTblEntry, field "alias" is actually above "join_using_alias", so the code comment could be updated to reflect the current field order:
>
> > join_using_alias is an alias clause attached directly to JOIN/USING. It is different from the alias field (below) in that it does not hide the

Nice catch. Will push the patch.

- Richard

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2025-09-21 23:59:20 Re: Fix wrong filename in header comment of gin_tuple.h
Previous Message Chao Li 2025-09-21 23:09:50 Fix wrong filename in header comment of gin_tuple.h