Re: [PATCH] Correct RangeTblEntry.join_using_alias comment to reflect field order

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: Steve Lau <stevelauc(at)outlook(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] Correct RangeTblEntry.join_using_alias comment to reflect field order
Date: 2025-09-22 00:49:19
Message-ID: CAApHDvoDufvUOQ=noix3w3hfNm2-mtYX5V7s7E56X0rQKCbqUw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 22 Sept 2025 at 11:56, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>
> On Sun, Sep 21, 2025 at 11:54 PM Steve Lau <stevelauc(at)outlook(dot)com> wrote:
> > Found a tiny incorrect comment of RangeTblEntry, field "alias" is actually above "join_using_alias", so the code comment could be updated to reflect the current field order:
> >
> > > join_using_alias is an alias clause attached directly to JOIN/USING. It is different from the alias field (below) in that it does not hide the
>
> Nice catch. Will push the patch.

I was just working on a script to find others and it highlighted a
bunch more. Do you still want to do this one, or should I take them
all in one fell swoop?

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2025-09-22 00:52:21 Re: [PATCH] Correct RangeTblEntry.join_using_alias comment to reflect field order
Previous Message Robert Haas 2025-09-22 00:26:00 Re: plan shape work