| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
| Cc: | Kirill Reshke <reshkekirill(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove unneeded cast in heap_xlog_lock. |
| Date: | 2025-08-22 14:01:41 |
| Message-ID: | CAMbWs49fO0ihKZdXg6mzW3jsfQiWj011rn+iSgjV6ZEmFVqJWA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Aug 22, 2025 at 6:59 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
> On 2025-Aug-22, Kirill Reshke wrote:
> > I am uncertain about the delineation between when we make changes and
> > when we refrain from doing so.
> I think this is natural work after 9c727360bcc7, before which
> BufferGetPage() was a macro and strangely enough had its own cast
> embedded. As I understand, the less casts we have, the better. There's
> some other standardization work going on to remove unnecessary casts
> elsewhere, so I'm not sure why we wouldn't do this.
I don't have a strong opinion on whether we should do this cleanup or
not. I'm a bit concerned about the code churn, given that there are
69 instances spread across 22 files. But maybe I'm worrying over
nothing, as we've done similar cleanups before to remove unnecessary
casts.
Thanks
Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-08-22 14:05:56 | Re: Don't treat virtual generated columns as missing statistics in vacuumdb --missing-stats-only |
| Previous Message | Nathan Bossart | 2025-08-22 14:01:36 | Re: vacuumdb --missing-stats-only and permission issue |