| From: | Álvaro Herrera <alvherre(at)kurilemu(dot)de> |
|---|---|
| To: | Kirill Reshke <reshkekirill(at)gmail(dot)com> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Remove unneeded cast in heap_xlog_lock. |
| Date: | 2025-08-22 09:59:31 |
| Message-ID: | 202508220959.34b6a4whnzwf@alvherre.pgsql |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2025-Aug-22, Kirill Reshke wrote:
> I am uncertain about the delineation between when we make changes and
> when we refrain from doing so.
I think this is natural work after 9c727360bcc7, before which
BufferGetPage() was a macro and strangely enough had its own cast
embedded. As I understand, the less casts we have, the better. There's
some other standardization work going on to remove unnecessary casts
elsewhere, so I'm not sure why we wouldn't do this.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"El que vive para el futuro es un iluso, y el que vive para el pasado,
un imbécil" (Luis Adler, "Los tripulantes de la noche")
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kirill Reshke | 2025-08-22 10:00:17 | Re: misleading error message in ProcessUtilitySlow T_CreateStatsStmt |
| Previous Message | Zhijie Hou (Fujitsu) | 2025-08-22 09:57:00 | RE: Add support for specifying tables in pg_createsubscriber. |