Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, 邱宇航 <iamqyh(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master
Date: 2025-10-21 03:58:53
Message-ID: CAMbWs49_u=cuQzoFFzX9JHDmNeNQdpX2wvv6jdtuUmOt6xB5JA@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Oct 21, 2025 at 12:26 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> > Regarding the tests, I think we could add another test query to cover
> > the case with no empty grouping sets and degenerate HAVING clauses.
> > This way, all cases for the HAVING pushdown optimization with grouping
> > sets should be covered.
>
> > I've added such a test in v5, along with a commit message. Nothing
> > else has changed. I'll push this patch soon, barring any objections.

> v5 LGTM.

Cool! I've pushed and back-patched v5. Thanks for working on this
patch.

邱宇航, thanks for the report -- it's a good one. This issue should
be fixed in 18.1, which is scheduled for release in November (the
13th, I believe).

- Richard

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message jian he 2025-10-21 04:00:28 Re: remove unnecessary include in src/backend/commands/policy.c
Previous Message Tom Lane 2025-10-21 03:37:12 Re: Add \pset options for boolean value display