Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, 邱宇航 <iamqyh(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master
Date: 2025-10-21 03:26:08
Message-ID: 416478.1761017168@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Richard Guo <guofenglinux(at)gmail(dot)com> writes:
> Regarding the tests, I think we could add another test query to cover
> the case with no empty grouping sets and degenerate HAVING clauses.
> This way, all cases for the HAVING pushdown optimization with grouping
> sets should be covered.

> I've added such a test in v5, along with a commit message. Nothing
> else has changed. I'll push this patch soon, barring any objections.

v5 LGTM.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message John Naylor 2025-10-21 03:30:30 Re: Proposal for enabling auto-vectorization for checksum calculations
Previous Message Richard Guo 2025-10-21 03:16:38 Re: Inconsistent Behavior of GROUP BY ROLLUP in v17 vs master