Re: Fix a typo of func DecodeInsert()

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Yongtao Huang <yongtaoh2022(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Fix a typo of func DecodeInsert()
Date: 2024-01-17 01:10:33
Message-ID: CAMbWs49TkAn4c8JJS=5E7q4y5WjShzu+ZzwztupTrx7v6-jHgQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Jan 17, 2024 at 8:47 AM Yongtao Huang <yongtaoh2022(at)gmail(dot)com>
wrote:

> Hi all,
> I think the comment above the function DecodeInsert()
> in src/backend/replication/logical/decode.c should be
> + * *Inserts *can contain the new tuple.
> , rather than
> - * *Deletes *can contain the new tuple.
>

Nice catch. +1.

I kind of wonder if it would be clearer to state that "XLOG_HEAP_INSERT
can contain the new tuple", in order to differentiate it from
XLOG_HEAP2_MULTI_INSERT.

Thanks
Richard

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2024-01-17 01:13:19 Re: Synchronizing slots from primary to standby
Previous Message Yongtao Huang 2024-01-17 00:46:55 Fix a typo of func DecodeInsert()