| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, jeremyevans0(at)gmail(dot)com, PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: BUG #17495: Regression in 15beta1 when filtering subquery including row_number window function |
| Date: | 2022-05-26 08:44:17 |
| Message-ID: | CAMbWs48zrWjc2EwbOqodP=UMu=p4u_tCic+OZ=YPD8P9AFiKpQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, May 26, 2022 at 4:22 PM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> On Thu, May 26, 2022 at 1:38 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
>
>> Yeah, I was aiming for a way to have it so the planner didn't
>> vandalise WindowClause.
>>
>> I've attached a patch which fixes the bug and does not require any
>> further modifications to WindowClause.
>>
>
> The patch looks sane to me, expect that line 122 in the patch introduces
> a whitespace-only line.
>
Another review comment:
- * extra_used_attrs can passed as non-NULL to mark any columns that we
should
+ * extra_used_attrs can be passed as non-NULL to mark any columns that we
should
Thanks
Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2022-05-26 14:40:03 | Re: BUG #17485: Records missing from Primary Key index when doing REINDEX INDEX CONCURRENTLY |
| Previous Message | Richard Guo | 2022-05-26 08:22:43 | Re: BUG #17495: Regression in 15beta1 when filtering subquery including row_number window function |