| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix comments for ChangeVarNodes() and related functions |
| Date: | 2025-11-05 03:47:37 |
| Message-ID: | CAMbWs48pfEMkTT_UAR5Co50jTKpOMX1UNMzUWSBYU_nAAVHWAQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 3, 2025 at 9:14 PM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> On 23.10.25 10:59, Richard Guo wrote:
> > I happend to notice this comment for ChangeVarNodes():
> >
> > * Specifying 'change_RangeTblRef' to false allows skipping RangeTblRef.
> > * See ChangeVarNodesExtended for details.
> >
> > However, I couldn't find "change_RangeTblRef" anywhere in the code
> > base. I suspect this is a leftover from development. In any case, I
> > think we should fix it.
> It appears that change_RangeTblRef was removed in commit ab42d643c14 but
> the comments were not fully adjusted.
Right. I've pushed this patch and backpatched it to v18. However,
this only covers ChangeVarNodes(). We still need a separate patch to
fix remove_rel_from_query().
- Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2025-11-05 04:00:00 | Re: Teaching planner to short-circuit empty UNION/EXCEPT/INTERSECT inputs |
| Previous Message | Michael Paquier | 2025-11-05 03:02:22 | Re: Extend injection_points_attach() to accept a user-defined function |