Re: Fix comments for ChangeVarNodes() and related functions

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Richard Guo <guofenglinux(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Fix comments for ChangeVarNodes() and related functions
Date: 2025-11-03 12:14:08
Message-ID: 12426221-27c4-4680-8839-8360721258c5@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 23.10.25 10:59, Richard Guo wrote:
> I happend to notice this comment for ChangeVarNodes():
>
> * Specifying 'change_RangeTblRef' to false allows skipping RangeTblRef.
> * See ChangeVarNodesExtended for details.
>
> However, I couldn't find "change_RangeTblRef" anywhere in the code
> base. I suspect this is a leftover from development. In any case, I
> think we should fix it.

It appears that change_RangeTblRef was removed in commit ab42d643c14 but
the comments were not fully adjusted.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Wolfgang Walther 2025-11-03 12:34:06 Re: 64 bit numbers vs format strings
Previous Message Vaibhav Dalvi 2025-11-03 11:59:30 Re: Non-text mode for pg_dumpall