| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Wrong unsafe-flag test in check_output_expressions() |
| Date: | 2026-06-03 00:51:29 |
| Message-ID: | CAMbWs48YpBiZdZiH6LSGCa6KY9qxd-kigwfV-QagMtCS_PtP7g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jun 3, 2026 at 7:32 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> On Wed, 3 Jun 2026 at 10:13, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> > On Wed, Jun 3, 2026 at 5:59 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > > Yes, that's not intentional. Your proposed fix looks correct. Are you
> > > happy to go ahead with pushing and backpatching that?
> > Thanks for taking a look. Yeah, I'm happy to push that. I'm kind of
> > unsure whether this needs to be back-patched, since it doesn't lead to
> > wrong plans, so it isn't a live bug in practice.
> I'd prefer it to be fully gone in all versions that have it, if you
> don't mind doing that.
Done. Back-patched through v15, where the buggy check was first
introduced.
- Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2026-06-03 01:01:57 | Re: Unify parallel worker handling for index builds and instrumentation |
| Previous Message | Lukas Fittl | 2026-06-03 00:38:09 | Re: Unify parallel worker handling for index builds and instrumentation |