Re: Wrong unsafe-flag test in check_output_expressions()

From: David Rowley <dgrowleyml(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Wrong unsafe-flag test in check_output_expressions()
Date: 2026-06-02 22:32:43
Message-ID: CAApHDvokHMLg0-LBgdDRf_W-uBFNS-qs-cb+LDHXokUr3=9j8g@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, 3 Jun 2026 at 10:13, Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
>
> On Wed, Jun 3, 2026 at 5:59 AM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > Yes, that's not intentional. Your proposed fix looks correct. Are you
> > happy to go ahead with pushing and backpatching that?
>
> Thanks for taking a look. Yeah, I'm happy to push that. I'm kind of
> unsure whether this needs to be back-patched, since it doesn't lead to
> wrong plans, so it isn't a live bug in practice.

I'd prefer it to be fully gone in all versions that have it, if you
don't mind doing that.

David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2026-06-02 23:10:22 Re: deep copy with mutation?
Previous Message Andrey Chernyy 2026-06-02 22:29:27 Re: [PATCH] Fix libxml leaks in contrib/xml2 XPath functions