Re: Fix bogus Asserts in calc_non_nestloop_required_outer

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Aleksander Alekseev <aleksander(at)timescale(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix bogus Asserts in calc_non_nestloop_required_outer
Date: 2023-11-03 06:46:56
Message-ID: CAMbWs48Q77XpfKX-+RY7u6Kt51MKkHeD4rZKv=-u8AP6AOhz_A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Sep 7, 2023 at 11:09 PM Aleksander Alekseev <
aleksander(at)timescale(dot)com> wrote:

> Probably it's just because of my limited experience with the optimizer
> but I don't find the proposed change particularly straightforward. I
> would suggest adding a comment before the Assert's and/or a detailed
> commit message would be helpful.

Comment is now added above the Asserts. Thanks for taking an interest
in this.

Thanks
Richard

Attachment Content-Type Size
v2-0001-Fix-bogus-Asserts-in-calc_non_nestloop_required_outer.patch application/octet-stream 1.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeff Davis 2023-11-03 07:05:06 Re: Improve WALRead() to suck data directly from WAL buffers when possible
Previous Message Jeff Davis 2023-11-03 06:19:03 Inconsistent use of "volatile" when accessing shared memory?