Re: Fix bogus Asserts in calc_non_nestloop_required_outer

From: Aleksander Alekseev <aleksander(at)timescale(dot)com>
To: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Cc: Richard Guo <guofenglinux(at)gmail(dot)com>
Subject: Re: Fix bogus Asserts in calc_non_nestloop_required_outer
Date: 2023-09-07 15:09:40
Message-ID: CAJ7c6TOJUzUNxiiPgCNhrqTjnWwkgAF3dgK0JwmCQEZpGMF8=A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Richard,

> As stated in [1], all paths arriving here are parameterized by top
> parents, so we should check against top_parent_relids if it exists in
> the two Asserts.
>
> Attached is a patch fixing that.

Probably it's just because of my limited experience with the optimizer
but I don't find the proposed change particularly straightforward. I
would suggest adding a comment before the Assert's and/or a detailed
commit message would be helpful.

Other than that I can confirm that both branches in the Assert's are
executed and the tests pass in different test environments.

--
Best regards,
Aleksander Alekseev

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nazir Bilal Yavuz 2023-09-07 16:06:57 Build the docs if there are changes in docs and don't run other tasks if the changes are only in docs
Previous Message Damir Belyalov 2023-09-07 14:57:12 Re: Output affected rows in EXPLAIN