Re: Fix bogus Asserts in calc_non_nestloop_required_outer

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix bogus Asserts in calc_non_nestloop_required_outer
Date: 2024-01-05 19:14:30
Message-ID: CA+TgmoZcjTkXF155tbG7sf5F9n-LUozNiQehY28123STstdYjQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Nov 3, 2023 at 2:47 AM Richard Guo <guofenglinux(at)gmail(dot)com> wrote:
> Comment is now added above the Asserts. Thanks for taking an interest
> in this.

I'd like to suggest rewording this comment a little more. Here's my proposal:

Both of the paths passed to this function are still parameterized by
the topmost parent, because reparameterize_path_by_child() hasn't been
called yet. So, these sanity checks use the parent relids.

What do you think?

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2024-01-05 19:19:23 Re: the s_lock_stuck on perform_spin_delay
Previous Message Andres Freund 2024-01-05 19:11:39 Re: the s_lock_stuck on perform_spin_delay