| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Matheus Alcantara <matheusssilv97(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tender Wang <tndrwang(at)gmail(dot)com>, Paul George <p(dot)a(dot)george19(at)gmail(dot)com>, Andy Fan <zhihuifan1213(at)163(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Eager aggregation, take 3 |
| Date: | 2025-10-06 00:56:25 |
| Message-ID: | CAMbWs48H9gj4gJ356OzRMBShMbpP0tJX9GvEJaRLzOf0qscS_A@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Oct 4, 2025 at 5:03 AM Matheus Alcantara
<matheusssilv97(at)gmail(dot)com> wrote:
> I've disabled the cassert and executed the ANALYZE again before
> benchmarking and now I have similar results with a improvement on eager
> aggregate version:
>
> -- master
> Planning Time: 2.734 ms
> Execution Time: 5238.128 ms
>
> -- patched
> Planning Time: 2.578 ms
> Execution Time: 4732.584 ms
Great!
> The performance results look good to me. I don't have to much comments
> about the code although I'm still learning about the planner internals
> this patch seems in good shape to me.
Thanks for running the benchmark and reviewing the patch.
> I'm just attaching a new csv with the last results after running with
> cassert disabled and after executing ANALYZE. It looks good to me.
Yeah, the results look good this time. There are no performance
regressions; on the contrary, several queries actually show very
really nice improvements.
- Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2025-10-06 00:59:11 | Re: Eager aggregation, take 3 |
| Previous Message | Erik Wienhold | 2025-10-06 00:40:31 | Re: psql: Count all table footer lines in pager setup |