Re: Missing rules for queryjumblefuncs.{funcs,switch}.c for maintainer-clean

From: Richard Guo <guofenglinux(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>
Subject: Re: Missing rules for queryjumblefuncs.{funcs,switch}.c for maintainer-clean
Date: 2023-03-20 07:18:17
Message-ID: CAMbWs4-VtVQou2yo7R1kJoCb--_-3WHX8HAuGY+7MWFJDHV2Mw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Mar 20, 2023 at 2:43 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:

> Nathan has reported to me offlist that maintainer-clean was not doing
> its job for the files generated by gen_node_support.pl in
> src/backend/nodes/ for the query jumbling. Attached is a patch to
> take care of this issue.
>
> While on it, I have found a comment in the related README that was
> missing a refresh.
>
> Any objections or comments?

A minor comment for the README is that now we have five support
functions not four.

- outcome. (For some classes of node types, you don't need all four support
+ outcome. (For some classes of node types, you don't need all five support

Thanks
Richard

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shiy.fnst@fujitsu.com 2023-03-20 07:18:22 RE: Dropped and generated columns might cause wrong data on subs when REPLICA IDENTITY FULL
Previous Message Pavel Stehule 2023-03-20 07:01:13 Re: proposal: possibility to read dumped table's name from file