| From: | Richard Guo <guofenglinux(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: fixing typo in comment for restriction_is_or_clause |
| Date: | 2022-10-25 07:56:33 |
| Message-ID: | CAMbWs4-RXhgz0i4O1z62gt+bTLTM5vXYyYhgnius0j_txLH7hg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 25, 2022 at 3:37 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
wrote:
> On 2022-Oct-25, Richard Guo wrote:
>
> > Agree with your point. Do you think we can further make the one-line
> > function a macro or an inline function in the .h file?
>
> We can, but should we?
>
> > I think this function is called quite frequently during planning, so
> > maybe doing that would bring a little bit of efficiency.
>
> You'd need to measure it and show some gains.
Yeah, that is what has to be done to make it happen.
Thanks
Richard
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-10-25 08:33:31 | Re: Proposal: Adding isbgworker column to pg_stat_activity |
| Previous Message | Richard Guo | 2022-10-25 07:52:30 | Re: fixing typo in comment for restriction_is_or_clause |