Re: fixing typo in comment for restriction_is_or_clause

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Richard Guo <guofenglinux(at)gmail(dot)com>
Cc: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: fixing typo in comment for restriction_is_or_clause
Date: 2022-10-25 07:37:12
Message-ID: 20221025073712.fjw6pcinzrz2u4um@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2022-Oct-25, Richard Guo wrote:

> Agree with your point. Do you think we can further make the one-line
> function a macro or an inline function in the .h file?

We can, but should we?

> I think this function is called quite frequently during planning, so
> maybe doing that would bring a little bit of efficiency.

You'd need to measure it and show some gains.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Siempre hay que alimentar a los dioses, aunque la tierra esté seca" (Orual)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Richard Guo 2022-10-25 07:52:30 Re: fixing typo in comment for restriction_is_or_clause
Previous Message Alvaro Herrera 2022-10-25 07:37:08 Re: Issue in GIN fast-insert: XLogBeginInsert + Read/LockBuffer ordering