Re: [PATCH] pgweb: auth.py: make it possible to customize email address in error message

From: Akshat Jaimini <destrex271(at)gmail(dot)com>
To: Célestin Matte <celestin(dot)matte(at)cmatte(dot)me>, pgsql-www(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] pgweb: auth.py: make it possible to customize email address in error message
Date: 2023-12-20 16:05:05
Message-ID: CAMaW3Vg5ZVFkoFrb4mv7dvDKFOfxGwvPg8OUQSGBiOm40LS=SA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

We actually have a new tool that tests all the functionalities in the
website. So just wanted to run it through that before.

I'll run the tests against your gitlab mirror.

Checkout the harness here:
https://github.com/destrex271/pgweb-testing-harness

Regards,
Akshat Jaimini

On Wed, 20 Dec, 2023, 20:11 Célestin Matte, <celestin(dot)matte(at)cmatte(dot)me>
wrote:

> Hello,
>
> Not sure what you're asking — I don't have access to the pgweb repo
> Do you mean a pull request?
> My local copy is on gitlab:
> https://gitlab.com/cmatte/pgweb/-/tree/auth_email?ref_type=heads
>
> Regards,
>
> On 20/12/2023 14:32, Akshat Jaimini wrote:
> > Hi!
> > It would be great if we could test this patch with the testing harness
> to confirm that nothing would break(although I am sure nothing would but
> there's no harm in testing).
> >
> > Is it possible to setup a develop/testing branch on the pgweb repo from
> where the harness can pull it?
> >
> > Regards,
> > Akshat Jaimini
> >
> > On Tue, 19 Dec, 2023, 22:21 Célestin Matte, <celestin(dot)matte(at)cmatte(dot)me
> <mailto:celestin(dot)matte(at)cmatte(dot)me>> wrote:
> >
> > auth.py contains an error message with an hardcoded @postgresql.org
> <http://postgresql.org> email address.
> > This patch makes it possible to change it using a variable in the
> settings.
> > I used ADMINS because it already exists in pgweb with the correct
> value (and pgarchives), but that can be discussed as it doesn't exist in
> pglister.
> >
> > --
> > Célestin Matte
> >
>
> --
> Célestin Matte
>
>

In response to

Browse pgsql-www by date

  From Date Subject
Next Message Magnus Hagander 2023-12-20 19:16:30 Re: [PATCH] pgweb: auth.py: make it possible to customize email address in error message
Previous Message Célestin Matte 2023-12-20 12:56:42 pglister: monitor eximintegration queue with nagios?