Re: [PATCH] pgweb: auth.py: make it possible to customize email address in error message

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Célestin Matte <celestin(dot)matte(at)cmatte(dot)me>
Cc: pgsql-www(at)postgresql(dot)org
Subject: Re: [PATCH] pgweb: auth.py: make it possible to customize email address in error message
Date: 2023-12-20 19:16:30
Message-ID: CABUevEyjvzTA8QXjsd_-0bmxxR5--LEUWvPfXTiN7+fYoaLcZg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

On Tue, Dec 19, 2023 at 5:51 PM Célestin Matte <celestin(dot)matte(at)cmatte(dot)me> wrote:
>
> auth.py contains an error message with an hardcoded @postgresql.org email address.
> This patch makes it possible to change it using a variable in the settings.
> I used ADMINS because it already exists in pgweb with the correct value (and pgarchives), but that can be discussed as it doesn't exist in pglister.

Maybe the correct choice is to actually add it to pglister?

That said, having a fallback is probably still a good idea since we
have loads of servers that run this auth.py plugin, but for the
pglister specific thing I think that would be a reasonable thing to
expect?

--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/

In response to

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Magnus Hagander 2023-12-20 19:23:18 Re: pglister: monitor eximintegration queue with nagios?
Previous Message Akshat Jaimini 2023-12-20 16:05:05 Re: [PATCH] pgweb: auth.py: make it possible to customize email address in error message