Re: Add --system-identifier / -s option to pg_resetwal

On Wed, Feb 4, 2026 at 8:21 AM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:

> On Sun, Feb 1, 2026 at 6:33 AM Nikolay Samokhvalov <nik(at)postgres(dot)ai>
> wrote:
> >
> > Thank you for the review!
> >
> > Attached is v3 addressing your feedback:
>
> Thanks for updating the patch!
>
> With this patch, the test failed on my laptop as follows.
> Could you please take a look and fix it?
>
> $ make -s check -C src/bin/pg_resetwal/ PROVE_TESTS="t/001*"
> # +++ tap check in src/bin/pg_resetwal +++
> t/001_basic.pl .. 15/? # Tests were run but no plan was declared and
> done_testing() was not seen.
> # Looks like your test exited with 4 just after 82.
> t/001_basic.pl .. Dubious, test returned 4 (wstat 1024, 0x400)
> All 82 subtests passed
>
> Test Summary Report
> -------------------
> t/001_basic.pl (Wstat: 1024 Tests: 82 Failed: 0)
> Non-zero exit status: 4
> Parse errors: No plan found in TAP output
> Files=1, Tests=82, 4 wallclock secs ( 0.03 usr 0.01 sys + 0.31 cusr
> 0.65 csys = 1.00 CPU)
> Result: FAIL
> make: *** [check] Error 1
>

v4 attached: rebased, fixed the failing test + added coverage
for --dry-run.