| From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
|---|---|
| To: | Nikolay Samokhvalov <nik(at)postgres(dot)ai> |
| Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers mailing list <pgsql-hackers(at)postgresql(dot)org>, Andrey Borodin <amborodin(at)acm(dot)org>, Kirk Wolak <wolakk(at)gmail(dot)com> |
| Subject: | Re: Add --system-identifier / -s option to pg_resetwal |
| Date: | 2026-02-04 16:20:51 |
| Message-ID: | CAHGQGwGFdx2+aPg_UqbF4YQAsKrDB1SqhTyd20r1nsyF1j+s9g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Feb 1, 2026 at 6:33 AM Nikolay Samokhvalov <nik(at)postgres(dot)ai> wrote:
>
> Thank you for the review!
>
> Attached is v3 addressing your feedback:
Thanks for updating the patch!
With this patch, the test failed on my laptop as follows.
Could you please take a look and fix it?
$ make -s check -C src/bin/pg_resetwal/ PROVE_TESTS="t/001*"
# +++ tap check in src/bin/pg_resetwal +++
t/001_basic.pl .. 15/? # Tests were run but no plan was declared and
done_testing() was not seen.
# Looks like your test exited with 4 just after 82.
t/001_basic.pl .. Dubious, test returned 4 (wstat 1024, 0x400)
All 82 subtests passed
Test Summary Report
-------------------
t/001_basic.pl (Wstat: 1024 Tests: 82 Failed: 0)
Non-zero exit status: 4
Parse errors: No plan found in TAP output
Files=1, Tests=82, 4 wallclock secs ( 0.03 usr 0.01 sys + 0.31 cusr
0.65 csys = 1.00 CPU)
Result: FAIL
make: *** [check] Error 1
Regards,
--
Fujii Masao
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2026-02-04 16:26:35 | Re: Flush some statistics within running transactions |
| Previous Message | Sami Imseih | 2026-02-04 16:19:03 | Re: Flush some statistics within running transactions |