| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Gavin Flower <GavinFlower(at)archidevsys(dot)co(dot)nz> |
| Subject: | Re: Abbreviated keys for Numeric |
| Date: | 2015-03-24 05:46:17 |
| Message-ID: | CAM3SWZT7dKrB5KbhF6GxDWFS=FM-0mw5LiHuqRxP+CR87P=zaw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Mar 23, 2015 at 10:36 PM, Andrew Gierth
<andrew(at)tao11(dot)riddles(dot)org(dot)uk> wrote:
> Peter> (I simply operate on the raw Datum when hashing for hyperLogLog,
> Peter> in a similar manner to the text opclass, which is safe with 8
> Peter> byte datums + pass by value int64).
>
> But this paragraph makes no sense, and the code currently in varlena.c
> is just as wrong in its usage of hash_uint32 as I was.
Ugh, yes, not all varlena.c calls to hash_uint32() do the right thing.
But then, a number of existing ones don't. I'll need to make a pass
over this soon.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2015-03-24 07:03:39 | Re: Abbreviated keys for Numeric |
| Previous Message | Andrew Gierth | 2015-03-24 05:36:56 | Re: Abbreviated keys for Numeric |