Re: Abbreviated keys for Numeric

From: Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Peter Geoghegan <pg(at)heroku(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Gavin Flower <GavinFlower(at)archidevsys(dot)co(dot)nz>
Subject: Re: Abbreviated keys for Numeric
Date: 2015-03-24 07:03:39
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

So here's the latest (and, hopefully, last) version:

- adds diagnostic output from numeric_abbrev_abort using the trace_sort

- fixed Datum cs. uint32 issues in hash_uint32

- added a short comment about excess-k representation

- tweaked the indenting and comments a bit

I'm not particularly committed to any specific way of handling the
DEC_DIGITS issue. (I moved away from the "transparently skip
abbreviations" approach of the original because it seemed that reducing
#ifdefism in the code was a desirable feature.)

The INT64_MIN/MAX changes should be committed fairly soon. (I haven't
posted a patch for TRACE_SORT)

Andrew (irc:RhodiumToad)

Attachment Content-Type Size
numeric_sortsup_v5.patch text/x-patch 18.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2015-03-24 07:16:06 Re: Order of enforcement of CHECK constraints?
Previous Message Peter Geoghegan 2015-03-24 05:46:17 Re: Abbreviated keys for Numeric