Obsolete comment within execTuples.c

From: Peter Geoghegan <pg(at)heroku(dot)com>
To: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Obsolete comment within execTuples.c
Date: 2014-09-15 03:52:36
Message-ID: CAM3SWZSvVzYLVDYZeRdafc8EaZxqe7E1s4D3LjAu2aq6qJ1mjQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Header comments within execTuples.c state:

* - ExecutePlan() calls ExecSelect(), which passes the result slot
* to printtup(), which uses slot_getallattrs() to extract the
* individual Datums for printing.

This isn't true, though - the function ExecSelect() no longer exists.
This is because commit 8a5849b7ff24c637a1140c26fc171e45c9142005
removed it, as infrastructure for data-modifying CTEs. In fact,
ExecutePlan now directly and indifferently calls the receiveSlot.
tcop/dest stuff takes care of calling printtup(), which I guess is
what was originally intended by this comment (by which I mean, that
part probably isn't obsolete).

--
Peter Geoghegan

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-09-15 04:05:54 Re: Obsolete comment within execTuples.c
Previous Message Robert Haas 2014-09-15 01:20:54 Re: pgbench throttling latency limit