Re: Obsolete comment within execTuples.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Geoghegan <pg(at)heroku(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Obsolete comment within execTuples.c
Date: 2014-09-15 04:05:54
Message-ID: 632.1410753954@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Geoghegan <pg(at)heroku(dot)com> writes:
> Header comments within execTuples.c state:
> * - ExecutePlan() calls ExecSelect(), which passes the result slot
> * to printtup(), which uses slot_getallattrs() to extract the
> * individual Datums for printing.

> This isn't true, though - the function ExecSelect() no longer exists.

Hmm ... the adjacent comment about EndPlan is obsolete too, since
that function is now called ExecEndPlan.

I think the basic problem in both cases is that it didn't occur to us
to go looking for references to a static function in files other than
the one containing the static function.

More generally, though, it seems like the header comments in execTuples.c
are not the best place to document global behavior ...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2014-09-15 04:15:30 Re: Obsolete comment within execTuples.c
Previous Message Peter Geoghegan 2014-09-15 03:52:36 Obsolete comment within execTuples.c