From: | Peter Geoghegan <pg(at)heroku(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
Subject: | Re: pgsql: CREATE INDEX ... INCLUDING (column[, ...]) |
Date: | 2016-04-08 18:40:01 |
Message-ID: | CAM3SWZSK60bBgGZZRDLxmJs0MXms0x91aXJ_gjWU3w6im23Xjw@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Fri, Apr 8, 2016 at 11:31 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> I assume that the problem here is larger than just failure to adhere to
>> C89 comment style. Was this patch really ready to commit? I'm not very
>> happy that such a large patch went from "Needs review" to "Committed" in
>> the blink of an eye on the very last commitfest day ... and artifacts like
>> this aren't doing anything to increase my confidence in it.
>
> +1. I wonder if this should be reverted entirely.
I really wish I could have done more to help with this, but I didn't
do enough soon enough. Regrettably, I think that the patch just isn't
ready. For example, the way that expression indexes just aren't
handled is a cause for concern, as is the general way in which high
keys are modified during index builds. Interactions with logical
decoding are also a concern; there could be significant issues there,
but that analysis just didn't happen. I had significant
misunderstandings about the patch as recently as this week.
This should be reverted.
--
Peter Geoghegan
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2016-04-08 18:44:14 | Re: pgsql: CREATE INDEX ... INCLUDING (column[, ...]) |
Previous Message | Stephen Frost | 2016-04-08 18:38:37 | Re: pgsql: CREATE INDEX ... INCLUDING (column[, ...]) |
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2016-04-08 18:42:28 | Re: Speedup twophase transactions |
Previous Message | Robert Haas | 2016-04-08 18:39:57 | Re: [PATCH v12] GSSAPI encryption support |