| From: | Peter Geoghegan <pg(at)heroku(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Improve memory management for external sorts. |
| Date: | 2016-03-19 18:21:31 |
| Message-ID: | CAM3SWZQEGTc4_cJ=ug65ypyO=2A249va1=3DoY0Z=wvuh9iMSQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sat, Mar 19, 2016 at 6:38 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> It would be helpful if you could either (a) confirm that that patch
> still applies and that it has no issues of this type or (b) post an
> updated version.
I don't think that it has a problem with lacking the right int64
format specifiers. However, I had a bad feeling about integer overflow
of state->currentRun, and think I'll need to address that. After all,
if runs are now no longer 2x work_mem on average, it's not completely
ridiculous to imagine that being an issue on a misconfigured system.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2016-03-19 18:37:25 | pgsql: Typo fix. |
| Previous Message | Tom Lane | 2016-03-19 16:07:43 | pgsql: Build backend/parser/scan.l and interfaces/ecpg/preproc/pgc.l st |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2016-03-19 18:34:30 | Re: pgbench stats per script & other stuff |
| Previous Message | Jeff Janes | 2016-03-19 18:08:18 | Re: pgbench stats per script & other stuff |