| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Jeff Janes <jeff(dot)janes(at)gmail(dot)com> |
| Cc: | Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgbench stats per script & other stuff |
| Date: | 2016-03-19 18:34:30 |
| Message-ID: | 20160319183430.GA294957@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Jeff Janes wrote:
> On Sat, Mar 19, 2016 at 8:41 AM, Alvaro Herrera
> <alvherre(at)2ndquadrant(dot)com> wrote:
> > I pushed your 25, with some additional minor tweaks. I hope I didn't
> > break anything; please test.
>
> I'm now getting compiler warnings:
>
> gcc version 4.4.7 20120313 (Red Hat 4.4.7-16) (GCC)
>
>
> pgbench.c: In function 'process_builtin':
> pgbench.c:2765: warning: 'ps.stats.lag.sum2' is used uninitialized in
> this function
Fair complaints. I suppose the following should fix them?
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| pgbench-warns.patch | text/x-diff | 3.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2016-03-19 18:35:33 | Re: incorrect docs for pgbench / skipped transactions |
| Previous Message | Peter Geoghegan | 2016-03-19 18:21:31 | Re: [COMMITTERS] pgsql: Improve memory management for external sorts. |