| From: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> |
|---|---|
| To: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Dead code in Create/RenameRole() after RoleSpec changes related to CURRENT/SESSION_USER |
| Date: | 2015-06-09 09:59:38 |
| Message-ID: | CAM2+6=XURdesjwGfSKbsQOzEu+PsH7UZF71w5S_Rd5JYyrjKJg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I found some dead code in CREATE/RENAME ROLE code path.
Attached patch to remove those.
We have introduced RoleSpec and handled public and none role names in
grammar
itself. We do have these handling in CreateRole() and RenameRole() which is
NO more valid now.
Here is the related commit:
commit 31eae6028eca4365e7165f5f33fee1ed0486aee0
Author: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Date: Mon Mar 9 15:41:54 2015 -0300
Allow CURRENT/SESSION_USER to be used in certain commands ...
Thanks
--
Jeevan B Chalke
Principal Software Engineer, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| cleanup_public_none_rolename_check.patch | text/x-patch | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2015-06-09 10:58:59 | The Future of Aggregation |
| Previous Message | Shay Rojansky | 2015-06-09 08:42:37 | Re: Cancel race condition |