Re: Dead code in Create/RenameRole() after RoleSpec changes related to CURRENT/SESSION_USER

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Dead code in Create/RenameRole() after RoleSpec changes related to CURRENT/SESSION_USER
Date: 2015-07-20 16:48:37
Message-ID: 20150720164837.GU2301@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Jeevan Chalke wrote:

> I found some dead code in CREATE/RENAME ROLE code path.
>
> We have introduced RoleSpec and handled public and none role names in
> grammar
> itself. We do have these handling in CreateRole() and RenameRole()
> which is NO more valid now.

Right.

> Attached patch to remove those.

Pushed.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-07-20 16:59:41 Re: [HACKERS] object_classes array is broken, again
Previous Message Alvaro Herrera 2015-07-20 16:38:15 Re: Typo in comment in setrefs.c