| From: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: block-level incremental backup |
| Date: | 2019-08-07 09:46:43 |
| Message-ID: | CAM2+6=WV8_Lp9Fng3o8jKri3Wa21_0oxh6dunE5qdXvSWZQ6SQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 5, 2019 at 7:13 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Fri, Aug 2, 2019 at 9:13 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > + rc = system(copycmd);
>
> I don't think this patch should be calling system() in the first place.
>
So, do you mean we should just do fread() and fwrite() for the whole file?
I thought it is better if it was done by the OS itself instead of reading
1GB
into the memory and writing the same to the file.
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Jeevan Chalke
Technical Architect, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Liudmila Mantrova | 2019-08-07 09:48:29 | Re: s/rewinded/rewound/? |
| Previous Message | vignesh C | 2019-08-07 09:45:38 | Re: SegFault on 9.6.14 |