From: | Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> |
---|---|
To: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: block-level incremental backup |
Date: | 2019-08-07 09:52:12 |
Message-ID: | CALtqXTcyEVfts+QfCAk_kGNp8c_PviAN9hF-CSsgiHJ_bTD2dQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Aug 7, 2019 at 2:47 PM Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>
wrote:
>
>
> On Mon, Aug 5, 2019 at 7:13 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>
>> On Fri, Aug 2, 2019 at 9:13 AM vignesh C <vignesh21(at)gmail(dot)com> wrote:
>> > + rc = system(copycmd);
>>
>> I don't think this patch should be calling system() in the first place.
>>
>
> So, do you mean we should just do fread() and fwrite() for the whole file?
>
> I thought it is better if it was done by the OS itself instead of reading
> 1GB
> into the memory and writing the same to the file.
>
> It is not necessary to read the whole 1GB into Ram.
>
>> --
>> Robert Haas
>> EnterpriseDB: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
> --
> Jeevan Chalke
> Technical Architect, Product Development
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
>
--
Ibrar Ahmed
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2019-08-07 10:01:54 | Re: Remove HeapTuple and Buffer dependency for predicate locking functions |
Previous Message | Liudmila Mantrova | 2019-08-07 09:48:29 | Re: s/rewinded/rewound/? |