| From: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> |
|---|---|
| To: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Josh Kupershmidt <schmiddy(at)gmail(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> |
| Subject: | Re: patch: option --if-exists for pg_dump |
| Date: | 2014-01-30 11:59:39 |
| Message-ID: | CAM2+6=WMsD+55+prCEtb5XsHA=FJktixmXnm-FETjnzsxBUvYQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Pavel,
Now patch looks good to me and I think it is in good shape to pass it on to
the committer as well.
However, I have
- Tweaked few comments
- Removed white-space errors
- Fixed typos
- Fixed indentation
Attached patch with my changes. However entire design and code logic is
untouched.
Please have a quick look and pass it on to committor if you have no issues
OR
ask me to assign it to the committor, NO issues either way.
Feel free to reject my changes if you didn't like them.
Thanks
--
Jeevan B Chalke
Principal Software Engineer, Product Development
EnterpriseDB Corporation
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| dump-restore-if-exists-opt-2014-01-30-Jeevan.patch | text/x-diff | 12.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | MauMau | 2014-01-30 12:14:34 | Re: [bug fix] postgres.exe fails to start on Windows Server 2012 due to ASLR |
| Previous Message | Fujii Masao | 2014-01-30 11:57:02 | Re: [PATCH] Support for pg_stat_archiver view |