| From: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
|---|---|
| To: | Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Josh Kupershmidt <schmiddy(at)gmail(dot)com>, Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr> |
| Subject: | Re: patch: option --if-exists for pg_dump |
| Date: | 2014-01-30 12:46:34 |
| Message-ID: | CAFj8pRDADDrG3xAGGNOS2D6+ODo7y0+03W1R0YVfwviov_iPpQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello
All is ok
Thank you
Pavel
2014-01-30 Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>:
> Hi Pavel,
>
> Now patch looks good to me and I think it is in good shape to pass it on to
> the committer as well.
>
> However, I have
> - Tweaked few comments
> - Removed white-space errors
> - Fixed typos
> - Fixed indentation
>
> Attached patch with my changes. However entire design and code logic is
> untouched.
>
> Please have a quick look and pass it on to committor if you have no issues
> OR
> ask me to assign it to the committor, NO issues either way.
>
> Feel free to reject my changes if you didn't like them.
>
> Thanks
> --
> Jeevan B Chalke
> Principal Software Engineer, Product Development
> EnterpriseDB Corporation
> The Enterprise PostgreSQL Company
>
>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeevan Chalke | 2014-01-30 13:24:01 | Re: patch: option --if-exists for pg_dump |
| Previous Message | MauMau | 2014-01-30 12:30:00 | Re: [bug fix] "pg_ctl stop" times out when it should respond quickly |