| From: | Greg Stark <stark(at)mit(dot)edu> |
|---|---|
| To: | Peter Geoghegan <pg(at)bowt(dot)ie> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Brandur Leach <brandur(at)mutelight(dot)org>, Neha Khatri <nehakhatri5(at)gmail(dot)com>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] SortSupport for macaddr type |
| Date: | 2017-03-19 15:40:03 |
| Message-ID: | CAM-w4HP3Kw993tcbDe9pRNGA_sWSVaOysmSQBjCh7iVcJEeirQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 18 March 2017 at 22:22, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
>
> Out of idle curiosity, I decided to generate disassembly of both
> macaddr_cmp_internal(), and the patch's abbreviated comparator. The
> former consists of 49 x86-64 instructions at -02 on my machine,
> totaling 135 bytes of object code. The latter consists of only 10
> instructions, or 24 bytes of object code.
I wonder if there's something that could be optimized out of the
normal cmp function but we're defeating some compiler optimizations
with all our casts and aliasing.
--
greg
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2017-03-19 16:01:23 | Re: Create replication slot in pg_basebackup if requested and not yet present |
| Previous Message | Stephen Frost | 2017-03-19 14:25:24 | Re: Removing binaries (was: createlang/droplang deprecated) |