| From: | Peter Geoghegan <pg(at)bowt(dot)ie> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Brandur Leach <brandur(at)mutelight(dot)org>, Neha Khatri <nehakhatri5(at)gmail(dot)com>, Julien Rouhaud <julien(dot)rouhaud(at)dalibo(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] SortSupport for macaddr type |
| Date: | 2017-03-18 22:22:43 |
| Message-ID: | CAH2-WzmSOdXiWJBs7ZJO+WanE7TuQ6w4+_RkAGH_DyOhsts+9w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Mar 18, 2017 at 2:54 PM, Peter Geoghegan <pg(at)bowt(dot)ie> wrote:
> This seems fine to me, especially
> because it lets us compare macaddr using simple 3-way unsigned int
> comparisons, which isn't otherwise the case.
Out of idle curiosity, I decided to generate disassembly of both
macaddr_cmp_internal(), and the patch's abbreviated comparator. The
former consists of 49 x86-64 instructions at -02 on my machine,
totaling 135 bytes of object code. The latter consists of only 10
instructions, or 24 bytes of object code.
--
Peter Geoghegan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2017-03-18 22:40:42 | Composite IS NULL again, this time with plpgsql |
| Previous Message | Tom Lane | 2017-03-18 21:57:47 | Re: mat views stats |