| From: | Ted Yu <yuzhihong(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Getting rid of SQLValueFunction |
| Date: | 2022-11-20 23:15:34 |
| Message-ID: | CALte62zPfFW7R4r1otJ6OBYd_=SeOpO82F--n=Y7VgqhjpasBA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Nov 20, 2022 at 3:12 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Sun, Nov 20, 2022 at 08:21:10AM -0800, Ted Yu wrote:
> > For get_func_sql_syntax(), the code for cases
> > of F_CURRENT_TIME, F_CURRENT_TIMESTAMP, F_LOCALTIME and F_LOCALTIMESTAMP
> is
> > mostly the same.
> > Maybe we can introduce a helper so that code duplication is reduced.
>
> It would. Thanks for the suggestion.
>
> Do you like something like the patch 0002 attached? This reduces a
> bit the overall size of the patch. Both ought to be merged in the
> same commit, still it is easier to see the simplification created.
> --
> Michael
>
Hi,
Thanks for the quick response.
+ * timestamp. These require a specific handling with their typmod is given
+ * by the function caller through their SQL keyword.
typo: typmod is given -> typmod given
Other than the above, code looks good to me.
Cheers
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-11-20 23:19:06 | Re: Split index and table statistics into different types of stats |
| Previous Message | Michael Paquier | 2022-11-20 23:13:16 | Re: Add LZ4 compression in pg_dump |